Welcome Guest ( Log In | Register )

Bump Topic Topic Closed RSS Feed

Outline · [ Standard ] · Linear+

Bug Report Is that a bugs?, Need some confirmation?

views
     
TSjtcs87
post Nov 23 2007, 12:15 AM, updated 19y ago

╮(╯_╰)╭
*******
Senior Member
2,747 posts

Joined: Jan 2006
From: Unhealthy Earth

Dear Admin,

I'm found a bugs (Honestly i don't know whether is a bug or not), just have a look on it. Thanks. rclxub.gif
I notice it the announcement is been set at here about the [New Feature] Topic Today

Attached Image


Today Topic = green color, you look it at the time at the right hand side is write yesterday. Color still green on it. rclxub.gif

This post has been edited by jtcs87: Nov 23 2007, 12:48 AM
fruitie
post Nov 23 2007, 12:29 AM

Rise and Shine
Group Icon
Staff
72,930 posts

Joined: Sep 2005
From: KUL

Ya, I encountered that too. But it was gone around 1 a.m. hmm.gif
temptation1314
post Nov 23 2007, 02:45 AM

Specials : 1,000,000 Spam Post Attack
*******
Senior Member
2,287 posts

Joined: Jun 2007
From: Anno Domini Time Ultra: 1,000,000 Trans Am Attack!
doh.gif 8.44p.m. not yesterday for now?
fruitie
post Nov 23 2007, 02:51 AM

Rise and Shine
Group Icon
Staff
72,930 posts

Joined: Sep 2005
From: KUL

QUOTE(temptation1314 @ Nov 23 2007, 02:45 AM)
doh.gif 8.44p.m. not yesterday for now?
*
Can you at least read back what jtcs87 trying to say? doh.gif
As we know, any topic's title is coloured green means new topic for that day. Since it had already passed 12 a.m., one of the yesterday's topics is still in green colour. By right, it shouldn't be. smile.gif

This post has been edited by fruitie: Nov 23 2007, 02:53 AM
wKkaY
post Nov 23 2007, 04:03 AM

misutā supākoru
Group Icon
VIP
6,008 posts

Joined: Jan 2003
A topic is considered new (green) if it has been opened in the past 24 hours. That topic was 3++ hours old when you saw it, so it's green. Hope that clears the confusion.
TSjtcs87
post Nov 23 2007, 07:31 AM

╮(╯_╰)╭
*******
Senior Member
2,747 posts

Joined: Jan 2006
From: Unhealthy Earth

So it just means like the delay for that feature? whistling.gif
mcchin
post Nov 23 2007, 08:56 AM

SLAVA UKRAINI !
*******
Senior Member
3,902 posts

Joined: Jul 2005
From: Sin Lor, B'worth,Pg.
so instead of the green showing the new post of that day,
it shows new post within 24 hours.

if thats so
i have seen a bunch of greenie being pruned just after 00:00 daily

wierd
wKkaY
post Nov 23 2007, 09:37 AM

misutā supākoru
Group Icon
VIP
6,008 posts

Joined: Jan 2003
QUOTE(mcchin @ Nov 23 2007, 11:56 AM)
i have seen a bunch of greenie being pruned just after 00:00 daily

wierd
*

Whoops, your observation is sort of right. Looking at the code.. it does seem like it's supposed to flag them only when they're made on the same day.

CODE
       if( $ibforums->vars['pre_posted_today'] )
       {
           $today_time = gmdate('d,m,Y', (time() + $std->offset) );
           $topic_time = gmdate('d,m,Y', ($topic['start_date'] + $std->offset) );
           if( $topic_time == $today_time )
           {
               $topic['color_start'] = $ibforums->vars['pre_posted_today'];
               $topic['color_end']   = $ibforums->vars['end_posted_today'];
           }
       }


Except that $std->offset is undefined (perhaps this hack was for a different version of IPB). So the day boundaries were following GMT, i.e. 8 hours behind MYT. I've fixed it to add your personal timezone offset to the calculation. Hope that helps.
mcchin
post Nov 23 2007, 10:41 AM

SLAVA UKRAINI !
*******
Senior Member
3,902 posts

Joined: Jul 2005
From: Sin Lor, B'worth,Pg.
QUOTE(wKkaY @ Nov 23 2007, 09:37 AM)
Whoops, your observation is sort of right. Looking at the code.. it does seem like it's supposed to flag them only when they're made on the same day.

CODE
if( $ibforums->vars['pre_posted_today'] )
{
$today_time = gmdate('d,m,Y', (time() + $std->offset) );
$topic_time = gmdate('d,m,Y', ($topic['start_date'] + $std->offset) );
if( $topic_time == $today_time )
{
$topic['color_start'] = $ibforums->vars['pre_posted_today'];
$topic['color_end'] = $ibforums->vars['end_posted_today'];
}
}


Except that $std->offset is undefined (perhaps this hack was for a different version of IPB). So the day boundaries were following GMT, i.e. 8 hours behind MYT. I've fixed it to add your personal timezone offset to the calculation. Hope that helps.
*
eerr.. giberish to me
but thumbup.gif gud job anyway icon_rolleyes.gif
TSjtcs87
post Nov 23 2007, 12:30 PM

╮(╯_╰)╭
*******
Senior Member
2,747 posts

Joined: Jan 2006
From: Unhealthy Earth

Sorry for troublesome to WKkaY. cheers.gif

Topic ClosedOptions
 

Change to:
| Lo-Fi Version
0.0139sec    1.11    6 queries    GZIP Disabled
Time is now: 23rd December 2025 - 05:57 AM