First choise = Cloud, with encryption. zip with password or 7z with AES will do
then HDD with RAID level 1 or higher.

SSD RAID 10 if your daddy prints money or have gold mine

SSD last much longer and price has gone down considerably low,
mechanical stuff like HDD are bound to fail, and especially consumer grade HDD is bottom tier stuff.

Raid 1 or higher level preferred for redundancy,
Or just cloud, you could saved yourself a lot of headaches

You have to consider whether the reader can last 1000 years, or what interface can support the reader after 1000 years

My kind of m-disc, traveling in space
https://en.wikipedia.org/wiki/Voyager_Golden_Record

The 1000 years is kind of gimmick, just look at the PC storage io interface changed how many times, and storage media from magnetic to flash.

Wen don't know what next generation storage medium is, but right now best bang for buck is still cloud storage.
Unless you already own a PC.