I wouldn't rock them to sleep because then they would always want it. What I do instead is I rock them just enough for them to get drowsy then I straight away put them down to bed and leave them alone so that they will learn to fall asleep by themselves.

Have you also tried using white noise? That can help them sleep too.